Remove fai index from bowtie2 modules#11537
Merged
Kevin-Brockers merged 4 commits intoMay 11, 2026
Merged
Conversation
Member
|
Why do you remove it ? bowtie2 doesn't use / generate one ? |
Contributor
Author
|
Yes, doesn't use it. We had a discussion about it on slack, back then initially there was a consensus to add it. In the maintainer meeting you agreed on to not enforce to add indices to corresponding files. To keep things a bit more consistent with eg bwa i removed it again. |
muffato
approved these changes
May 11, 2026
Contributor
Author
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Removed the fai index from inputs in bowtie2 modules, updated corresponding modules, subworkflows and tests.
nf-core modules test <MODULE> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile docker